view MoinMoin/action/ @ 5910:7e7e1cbb9d3f

security: fix remote code execution vulnerability in twikidraw/anywikidraw actions We have wikiutil.taintfilename() to make user supplied filenames safe, so that they can't contain any "special" characters like path separators, etc. It is used at many places in moin, but wasn't used here. :|
author Thomas Waldmann <tw AT waldmann-edv DOT de>
date Sat, 29 Dec 2012 15:05:29 +0100
parents 660b7d2d77ed
line wrap: on
line source
# -*- coding: iso-8859-1 -*-
    MoinMoin - user settings action

    @copyright: 2006 Radomir Dopieralski
                2007, 2008 MoinMoin:JohannesBerg
    @license: GNU GPL, see COPYING for details.

from MoinMoin import Page, wikiutil
from MoinMoin.widget import html

def _handle_submission(request):
    """ Handle GET and POST requests of preferences forms.

    Return error msg_class, msg tuple or None, None.
    _ = request.getText
    sub = request.values.get('handler')

    if sub in request.cfg.userprefs_disabled:
        return None, None

        cls = wikiutil.importPlugin(request.cfg, 'userprefs', sub, 'Settings')
    except wikiutil.PluginMissingError:
        # we never show this plugin to click on so no need to
        # give a message here
        return None, None

    obj = cls(request)
    if not obj.allowed():
        return None, None
    res = obj.handle_form()
    if isinstance(res, tuple):
        return res
    # backward compatibility for userprefs plugins,
    # they just get 'dialog'-style messages.
    return None, res

def _create_prefs_page(request, sel=None):
    _ = request.getText
    plugins = wikiutil.getPlugins('userprefs', request.cfg)
    ret = html.P()
    ret.append(html.Text(_("Please choose:")))
    items = html.UL()
    for sub in plugins:
        if sub in request.cfg.userprefs_disabled:
        cls = wikiutil.importPlugin(request.cfg, 'userprefs', sub, 'Settings')
        obj = cls(request)
        if not obj.allowed():
        url =, {'action': 'userprefs', 'sub': sub})
        lnk = html.LI().append(html.A(href=url).append(html.Text(obj.title)))
    return unicode(ret)

def _create_page(request, cancel=False):
    # returns text, title, msg_class, msg
    pagename =

    if 'handler' in request.values:
        msg_class, msg = _handle_submission(request)
        msg_class, msg = None, None

    sub = request.args.get('sub', '')
    cls = None
    if sub and sub not in request.cfg.userprefs_disabled:
            cls = wikiutil.importPlugin(request.cfg, 'userprefs', sub, 'Settings')
        except wikiutil.PluginMissingError:
            # cls is already None

    obj = cls and cls(request)

    if not obj or not obj.allowed():
        return _create_prefs_page(request), None, msg_class, msg

    return obj.create_form(), obj.title, msg_class, msg

def execute(pagename, request):
    _ = request.getText
    if not request.user.valid:
        actname = __name__.split('.')[-1]
        request.theme.add_msg(_("You must login to use this action: %(action)s.") % {"action": actname}, "error")
        return Page.Page(request, pagename).send_page()

    text, title, msg_class, msg = _create_page(request)
    if title:
        # XXX: we would like to make "Settings" here a link back
        #      to the generic userprefs page but that is impossible
        #      due to the way the title is emitted and the theme is
        #      responsible for doing the linking....
        title = _("Settings") + ": " + title
        title = _("Settings")
    request.theme.add_msg(msg, msg_class)
    request.theme.send_title(title,, pagename=pagename)
    # Start content (important for RTL support)