changeset 1799:06ce4843b9b5

remove some XXX strings
author Thomas Waldmann <tw AT waldmann-edv DOT de>
date Fri, 23 Feb 2007 22:04:08 +0100
parents 57f12932915f
children e8a309cad6b7
files MoinMoin/_tests/broken/test_parser_text_moin_wiki.py MoinMoin/action/SyncPages.py MoinMoin/action/rss_rc.py MoinMoin/config/multiconfig.py MoinMoin/theme/__init__.py MoinMoin/xmlrpc/__init__.py
diffstat 6 files changed, 16 insertions(+), 14 deletions(-) [+]
line wrap: on
line diff
--- a/MoinMoin/_tests/broken/test_parser_text_moin_wiki.py	Fri Feb 23 20:31:08 2007 +0100
+++ b/MoinMoin/_tests/broken/test_parser_text_moin_wiki.py	Fri Feb 23 22:04:08 2007 +0100
@@ -162,7 +162,7 @@
    machine? - can we fix this?
    """
    
-   text = 'XXX %s XXX'
+   text = 'AAA %s AAA'
    needle = re.compile(text %  r'(.+)')
    _tests = (
        # test                                   expected
@@ -200,7 +200,7 @@
 class TextFormatingTestCase(ParserTestCase):
     """ Test wiki markup """
     
-    text = 'XXX %s XXX'
+    text = 'AAA %s AAA'
     needle = re.compile(text %  r'(.+)')
     _tests = (
         # test,                     expected
@@ -416,12 +416,12 @@
 
     def testParagraphBeforeBlock(self):
         """ parser.wiki: paragraph closed before block element """
-        text = """XXX
+        text = """AAA
 %s
 """
         for test, blockstart in self.cases:
             # We dont test here formatter white space generation
-            expected = r'<p>XXX\s*</p>\n+%s' % blockstart
+            expected = r'<p>AAA\s*</p>\n+%s' % blockstart
             needle = re.compile(expected, re.MULTILINE)
             result = self.parse(text % test)
             match = needle.search(result)
@@ -437,12 +437,12 @@
         Currently an empty paragraph is created, which make no sense but
         no real harm.
         """
-        text = """XXX
+        text = """AAA
 
 %s
 """
         for test, blockstart in self.cases:
-            expected = r'<p>XXX\s*</p>\n+%s' % blockstart
+            expected = r'<p>AAA\s*</p>\n+%s' % blockstart
             needle = re.compile(expected, re.MULTILINE)
             result = self.parse(text % test)
             match = needle.search(result)
--- a/MoinMoin/action/SyncPages.py	Fri Feb 23 20:31:08 2007 +0100
+++ b/MoinMoin/action/SyncPages.py	Fri Feb 23 22:04:08 2007 +0100
@@ -102,8 +102,8 @@
             "pageList": None,
             "groupList": None,
             "direction": "foo", # is defaulted below
-            "user": None,     # this should be refactored into a password agent
-            "password": None, # or OpenID like solution (XXX)
+            "user": None, # XXX should be refactored into a password agent or OpenID like solution
+            "password": None,
         }
 
         options.update(Dict(self.request, self.pagename).get_dict())
--- a/MoinMoin/action/rss_rc.py	Fri Feb 23 20:31:08 2007 +0100
+++ b/MoinMoin/action/rss_rc.py	Fri Feb 23 22:04:08 2007 +0100
@@ -21,8 +21,10 @@
     """ Send recent changes as an RSS document
     """
     if not wikixml.ok:
-        #XXX send error message
-        pass
+        httpheaders = ["Content-Type: text/plain; charset=%s" % config.charset]
+        request.emit_http_headers(httpheaders)
+        request.write("rss_rc action is not supported because of missing pyxml module.")
+        return
 
     cfg = request.cfg
 
--- a/MoinMoin/config/multiconfig.py	Fri Feb 23 20:31:08 2007 +0100
+++ b/MoinMoin/config/multiconfig.py	Fri Feb 23 22:04:08 2007 +0100
@@ -429,7 +429,7 @@
     # it confused many people by its name and default value of '/wiki' to the
     # wrong conclusion that it is the url of the wiki (the dynamic) stuff,
     # but it was used to address the static stuff (images, css, js).
-    # Thus we use the more clear url_prefix_static ['/staticXXX'] setting now.
+    # Thus we use the more clear url_prefix_static ['/moin_staticVVV'] setting now.
     # For a limited time, we still look at url_prefix - if it is not None, we
     # copy the value to url_prefix_static to ease transition.
     url_prefix = None
--- a/MoinMoin/theme/__init__.py	Fri Feb 23 20:31:08 2007 +0100
+++ b/MoinMoin/theme/__init__.py	Fri Feb 23 22:04:08 2007 +0100
@@ -1466,7 +1466,7 @@
         page_user_prefs = wikiutil.getLocalizedPage(request, 'UserPreferences').page_name
         page_help_formatting = wikiutil.getLocalizedPage(request, 'HelpOnFormatting').page_name
         page_find_page = wikiutil.getLocalizedPage(request, 'FindPage').page_name
-        home_page = wikiutil.getInterwikiHomePage(request) # XXX sorry theme API change!!! Either None or tuple (wikiname,pagename) now.
+        home_page = wikiutil.getInterwikiHomePage(request) # sorry theme API change!!! Either None or tuple (wikiname,pagename) now.
         page_parent_page = getattr(page.getParentPage(), 'page_name', None)
 
         # Prepare the HTML <head> element
--- a/MoinMoin/xmlrpc/__init__.py	Fri Feb 23 20:31:08 2007 +0100
+++ b/MoinMoin/xmlrpc/__init__.py	Fri Feb 23 22:04:08 2007 +0100
@@ -347,8 +347,8 @@
         """ Return page information for specific revision
         
         @param pagename: the name of the page (utf-8)
-        @param rev: revision to get info about (XXX int?)
-        @rtype: dict XXX ??
+        @param rev: revision to get info about (int)
+        @rtype: dict
         @return: page information
             * name (string): the canonical page name, UTF-8.
             * lastModified (date): Last modification date, UTC.