Mercurial > moin > 1.9

changeset 3011:5913913a4dc0

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
MonthCalendar: avoid even bad behaved bots reading more than current year +/- 1 in the calendar, rel=nofollow for links to nonexisting day pages (port from 1.6)
author Thomas Waldmann <tw AT waldmann-edv DOT de>
date Sun, 06 Jan 2008 19:18:19 +0100
parents b4f97b0939ba
children ca0bf3aefa0f
files MoinMoin/macro/MonthCalendar.py
diffstat 1 files changed, 18 insertions(+), 8 deletions(-) [+]
line wrap: on
line diff
--- a/MoinMoin/macro/MonthCalendar.py	Sun Jan 06 19:13:12 2008 +0100
+++ b/MoinMoin/macro/MonthCalendar.py	Sun Jan 06 19:18:19 2008 +0100
@@ -248,6 +248,13 @@
     else:
         year, month = yearmonthplusoffset(parmyear, parmmonth, parmoffset)
 
+    if request.isSpiderAgent and abs(currentyear - year) > 1:
+        return '' # this is a bot and it didn't follow the rules (see below)
+    if currentyear == year:
+        attrs = {}
+    else:
+        attrs = {'rel': 'nofollow' } # otherwise even well-behaved bots will index forever
+
     # get the calendar
     monthcal = calendar.monthcalendar(year, month)
 
@@ -270,10 +277,11 @@
     nextlink = p.url(request, querystr % (qpagenames, parmoffset2 + 1, qtemplate), relative=False)
     prevylink = p.url(request, querystr % (qpagenames, parmoffset2 - 12, qtemplate), relative=False)
     nextylink = p.url(request, querystr % (qpagenames, parmoffset2 + 12, qtemplate), relative=False)
-    prevmonth = formatter.url(1, prevlink, 'cal-link') + '&lt;' + formatter.url(0)
-    nextmonth = formatter.url(1, nextlink, 'cal-link') + '&gt;' + formatter.url(0)
-    prevyear = formatter.url(1, prevylink, 'cal-link') + '&lt;&lt;' + formatter.url(0)
-    nextyear = formatter.url(1, nextylink, 'cal-link') + '&gt;&gt;' + formatter.url(0)
+
+    prevmonth = formatter.url(1, prevlink, 'cal-link', **attrs) + '&lt;' + formatter.url(0)
+    nextmonth = formatter.url(1, nextlink, 'cal-link', **attrs) + '&gt;' + formatter.url(0)
+    prevyear = formatter.url(1, prevylink, 'cal-link', **attrs) + '&lt;&lt;' + formatter.url(0)
+    nextyear = formatter.url(1, nextylink, 'cal-link', **attrs) + '&gt;&gt;' + formatter.url(0)
 
     if parmpagename != [thispage]:
         pagelinks = ''
@@ -289,6 +297,7 @@
             ch = parmpagename[0][st:st+chstep]
             r, g, b = cliprgb(r, g, b)
             link = Page(request, parmpagename[0]).link_to(request, ch,
+                        rel='nofollow',
                         style='background-color:#%02x%02x%02x;color:#000000;text-decoration:none' % (r, g, b))
             pagelinks = pagelinks + link
             r, g, b = (r, g+colorstep, b)
@@ -296,6 +305,7 @@
         r, g, b = (255-colorstep, 255, 255-colorstep)
         for page in parmpagename[1:]:
             link = Page(request, page).link_to(request, page,
+                        rel='nofollow',
                         style='background-color:#%02x%02x%02x;color:#000000;text-decoration:none' % (r, g, b))
             pagelinks = pagelinks + '*' + link
         showpagename = '   %s<BR>\n' % pagelinks
@@ -359,8 +369,8 @@
                     tiptitle = link
                     tiptext = '<br>'.join(titletext)
                     maketip_js.append("maketip('%s','%s','%s');" % (tipname, tiptitle, tiptext))
-                    onmouse = {'onMouseOver': "tip('%s')" % tipname,
-                               'onMouseOut': "untip()"}
+                    attrs = {'onMouseOver': "tip('%s')" % tipname,
+                             'onMouseOut': "untip()"}
                 else:
                     csslink = "cal-emptyday"
                     if parmtemplate:
@@ -370,7 +380,7 @@
                     r, g, b, u = (255, 255, 255, 0)
                     if wkday in wkend:
                         csslink = "cal-weekend"
-                    onmouse = {}
+                    attrs = {'rel': 'nofollow'}
                 for otherpage in parmpagename[1:]:
                     otherlink = "%s/%4d-%02d-%02d" % (otherpage, year, month, day)
                     otherdaypage = Page(request, otherlink)
@@ -382,7 +392,7 @@
                             r, g, b = (r, g+colorstep, b)
                 r, g, b = cliprgb(r, g, b)
                 style = 'background-color:#%02x%02x%02x' % (r, g, b)
-                fmtlink = formatter.url(1, daypage.url(request, query, relative=False), csslink, **onmouse) + str(day) + formatter.url(0)
+                fmtlink = formatter.url(1, daypage.url(request, query, relative=False), csslink, **attrs) + str(day) + formatter.url(0)
                 if day == currentday and month == currentmonth and year == currentyear:
                     cssday = "cal-today"
                     fmtlink = "<b>%s</b>" % fmtlink # for browser with CSS probs