changeset 2476:8a118b01df5a

Merge main.
author Karol 'grzywacz' Nowak <grzywacz@sul.uni.lodz.pl>
date Fri, 20 Jul 2007 22:04:55 +0200
parents 639a122cbc54 (current diff) 45641cbe7729 (diff)
children 0242ded135e9
files MoinMoin/support/copy.py
diffstat 11 files changed, 132 insertions(+), 463 deletions(-) [+]
line wrap: on
line diff
--- a/MoinMoin/_tests/pep8.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/MoinMoin/_tests/pep8.py	Fri Jul 20 22:04:55 2007 +0200
@@ -99,6 +99,10 @@
 
 indent_match = re.compile(r'([ \t]*)').match
 raise_comma_match = re.compile(r'raise\s+\w+\s*(,)').match
+equals_boolean_search = re.compile(r'([!=]=\s*(True|False))|((True|False)\s*[!=]=)').search
+equals_None_search = re.compile(r'([!=]=\s*None)|(None\s*[!=]=)').search
+
+not_one_ws_around_operators_match = re.compile(r'^[^\(\[]+[^\s](\+|\-|\*|/|%|\^|&|\||=|<|>|>>|<<|\+=|\-=|\*=|/=|%=|\^=|&=|\|=|==|<=|>=|>>=|<<=|!=|<>)[^\s][^\)\]]+$').match
 
 operators = """
 +  -  *  /  %  ^  &  |  =  <  >  >>  <<
@@ -316,7 +320,7 @@
         prev_end = end
 
 
-def whitespace_around_operator(logical_line):
+def extra_whitespace_around_operator(logical_line):
     """
     Avoid extraneous whitespace in the following situations:
 
@@ -339,6 +343,15 @@
             return found, "E224 tab after operator"
 
 
+def whitespace_around_operator(logical_line):
+    """
+    Have exactly 1 space left and right of the operator.
+    """
+    match = not_one_ws_around_operators_match(logical_line)
+    if match and not 'lambda' in logical_line:
+        return match.start(1), "E225 operators shall be surrounded by a single space on each side %s" % logical_line
+
+
 def whitespace_around_comma(logical_line):
     """
     Avoid extraneous whitespace in the following situations:
@@ -415,6 +428,34 @@
         return match.start(1), "W602 deprecated form of raising exception"
 
 
+def dumb_equals_boolean(logical_line):
+    """
+    Using "if x == True:" or "if x == False:" is wrong in any case:
+
+    First if you already have a boolean, you don't need to compare it to
+    another boolean. Just use "if x:" or "if not x:".
+
+    Second, even if you have some sort of "tristate logic", not only using
+    True/False, but other values, then you want to use "if x is True:" or
+    "if x is False:" because there is exactly one True and one False object.
+    """
+    match = equals_boolean_search(logical_line)
+    if match:
+        return match.start(1), "E798 don't use 'x == <boolean>', but just 'x' or 'not x' or 'x is <boolean>'"
+
+
+def dumb_equals_None(logical_line):
+    """
+    Using "if x == None:" is wrong in any case:
+
+    You either want to use "if x is None:" (there is only 1 None object) or -
+    in some simple cases - just "if not x:".
+    """
+    match = equals_None_search(logical_line)
+    if match:
+        return match.start(1), "E799 don't use 'x == None', but just 'x is None' or 'not x'"
+
+
 ##############################################################################
 # Helper functions
 ##############################################################################
--- a/MoinMoin/_tests/test_sourcecode.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/MoinMoin/_tests/test_sourcecode.py	Fri Jul 20 22:04:55 2007 +0200
@@ -29,8 +29,8 @@
                              # use 'fix' with extreme caution and in a separate changeset!
 FIX_TS_RE = re.compile(r' +$', re.M) # 'fix' mode: everything matching the trailing space re will be removed
 
-
 RECENTLY = time.time() - 7 * 24*60*60 # we only check stuff touched recently.
+#RECENTLY = 0 # check everything!
 # After doing a fresh clone, this procedure is recommended:
 # 1. Run the tests once to see if everything is OK (as cloning updates the mtime,
 #    it will test every file).
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/MoinMoin/config/_tests/test_multiconfig.py	Fri Jul 20 22:04:55 2007 +0200
@@ -0,0 +1,66 @@
+# -*- coding: iso-8859-1 -*-
+"""
+    MoinMoin - MoinMoin.config.multiconfig Tests
+
+    @copyright: 2007 by MoinMoin:ThomasWaldmann
+    @license: GNU GPL, see COPYING for details.
+"""
+
+try:
+    set
+except:
+    from sets import Set as set
+
+import py
+
+
+class TestPasswordChecker:
+    username = u"SomeUser"
+    tests_builtin = [
+        (u'', False), # empty
+        (u'1966', False), # too short
+        (u'asdfghjk', False), # keyboard sequence
+        (u'QwertZuiop', False), # german keyboard sequence, with uppercase
+        (u'mnbvcx', False), # reverse keyboard sequence
+        (u'12345678', False), # keyboard sequence, too easy
+        (u'aaaaaaaa', False), # not enough different chars
+        (u'BBBaaaddd', False), # not enough different chars
+        (username, False), # username == password
+        (username[1:-1], False), # password in username
+        (u"XXX%sXXX" % username, False), # username in password
+        (u'Moin-2007', True), # this should be OK
+    ]
+    tests_crack = tests_builtin + [
+        (u'secret', False), # word from dictionary
+        (u'password', False), # word from dictionary
+    ]
+    def testBuiltinPasswordChecker(self):
+        pw_checker = self.request.cfg.password_checker
+        if not pw_checker:
+            py.test.skip("password_checker is disabled in the configuration, not testing it")
+        else:
+            for pw, result in self.tests_builtin:
+                pw_error = pw_checker(self.username, pw)
+                print "%r: %s" % (pw, pw_error)
+                assert result == (pw_error is None)
+
+    def testCrackPasswordChecker(self):
+        pw_checker = self.request.cfg.password_checker
+        if not pw_checker:
+            py.test.skip("password_checker is disabled in the configuration, not testing it")
+        else:
+            try:
+                import crack # do we have python-crack?
+            except:
+                py.test.skip("python-crack is not installed")
+            try:
+                crack.FascistCheck("a12fv./ZX47") # this should not raise an exception
+            except:
+                py.test.skip("python-crack is not working correctly (did you forget to build the dicts?)")
+            else:
+                for pw, result in self.tests_crack:
+                    pw_error = pw_checker(self.username, pw)
+                    print "%r: %s" % (pw, pw_error)
+                    assert result == (pw_error is None)
+
+
--- a/MoinMoin/config/multiconfig.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/MoinMoin/config/multiconfig.py	Fri Jul 20 22:04:55 2007 +0200
@@ -447,15 +447,18 @@
         try:
             # in any case, do a very simple built-in check to avoid the worst passwords
             if len(password) < 6:
-                raise ValueError("Password too short!")
+                raise ValueError("Password too short.")
+            if len(set(password)) < 4:
+                raise ValueError("Password has not enough different characters.")
 
             username_lower = username.lower()
             password_lower = password.lower()
             if username in password or password in username or \
                username_lower in password_lower or password_lower in username_lower:
-                raise ValueError("Password too easy (containment)")
+                raise ValueError("Password too easy (containment).")
 
             keyboards = (ur"`1234567890-=qwertyuiop[]\asdfghjkl;'zxcvbnm,./", # US kbd
+                         ur"^1234567890ß´qwertzuiopü+asdfghjklöä#yxcvbnm,.-", # german kbd
                         ) # add more keyboards!
             for kbd in keyboards:
                 rev_kbd = kbd[::-1]
@@ -649,8 +652,8 @@
 
     user_homewiki = 'Self' # interwiki name for where user homepages are located
 
-    unzip_single_file_size = 2.0 * 1000**2
-    unzip_attachments_space = 200.0 * 1000**2
+    unzip_single_file_size = 2.0 * 1000 ** 2
+    unzip_attachments_space = 200.0 * 1000 ** 2
     unzip_attachments_count = 101 # 1 zip file + 100 files contained in it
 
     xmlrpc_putpage_enabled = False # if False, putpage will write to a test page only
--- a/MoinMoin/formatter/text_html.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/MoinMoin/formatter/text_html.py	Fri Jul 20 22:04:55 2007 +0200
@@ -710,7 +710,7 @@
             except OSError:
                 pass
             else:
-                mapid = 'ImageMapOf'+drawing
+                mapid = 'ImageMapOf' + drawing
                 # replace MAPNAME
                 map = map.replace('%MAPNAME%', mapid)
                 # add alt and title tags to areas
--- a/MoinMoin/request/__init__.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/MoinMoin/request/__init__.py	Fri Jul 20 22:04:55 2007 +0200
@@ -9,7 +9,6 @@
 
 import os, re, time, sys, cgi, StringIO
 import logging
-import copy
 import Cookie
 
 try:
@@ -300,15 +299,15 @@
                         t = int(t)
                         maxnum, dt = limits.get(action, default_limit)
                         if t >= now - dt:
-                            events = surgedict.setdefault(id, copy.copy({}))
-                            timestamps = events.setdefault(action, copy.copy([]))
+                            events = surgedict.setdefault(id, {})
+                            timestamps = events.setdefault(action, [])
                             timestamps.append((t, surge_indicator))
                     except StandardError:
                         pass
 
             maxnum, dt = limits.get(current_action, default_limit)
-            events = surgedict.setdefault(current_id, copy.copy({}))
-            timestamps = events.setdefault(current_action, copy.copy([]))
+            events = surgedict.setdefault(current_id, {})
+            timestamps = events.setdefault(current_action, [])
             surge_detected = len(timestamps) > maxnum
 
             surge_indicator = surge_detected and "!" or ""
@@ -320,8 +319,8 @@
             if current_action != 'AttachFile': # don't add AttachFile accesses to all or picture galleries will trigger SP
                 current_action = 'all' # put a total limit on user's requests
                 maxnum, dt = limits.get(current_action, default_limit)
-                events = surgedict.setdefault(current_id, copy.copy({}))
-                timestamps = events.setdefault(current_action, copy.copy([]))
+                events = surgedict.setdefault(current_id, {})
+                timestamps = events.setdefault(current_action, [])
 
                 if kick_him: # ban this guy, NOW
                     timestamps.extend([(now + self.cfg.surge_lockout_time, "!")] * (2*maxnum))
--- a/MoinMoin/support/copy.py	Fri Jul 20 13:27:41 2007 +0200
+++ /dev/null	Thu Jan 01 00:00:00 1970 +0000
@@ -1,444 +0,0 @@
-"""This is a (modified) copy of python 2.4.2 copy.py as it was broken in:
-   Python 2.3.x, x < 5
-   Python 2.4.x, x < 1
-
-   Modifications done are minimal, so that same copy.py can work under 2.3
-   and 2.4 python (try: ... except: ... around some set stuff).
-
-Generic (shallow and deep) copying operations.
-
-Interface summary:
-
-        import copy
-
-        x = copy.copy(y)        # make a shallow copy of y
-        x = copy.deepcopy(y)    # make a deep copy of y
-
-For module specific errors, copy.Error is raised.
-
-The difference between shallow and deep copying is only relevant for
-compound objects (objects that contain other objects, like lists or
-class instances).
-
-- A shallow copy constructs a new compound object and then (to the
-  extent possible) inserts *the same objects* into it that the
-  original contains.
-
-- A deep copy constructs a new compound object and then, recursively,
-  inserts *copies* into it of the objects found in the original.
-
-Two problems often exist with deep copy operations that don't exist
-with shallow copy operations:
-
- a) recursive objects (compound objects that, directly or indirectly,
-    contain a reference to themselves) may cause a recursive loop
-
- b) because deep copy copies *everything* it may copy too much, e.g.
-    administrative data structures that should be shared even between
-    copies
-
-Python's deep copy operation avoids these problems by:
-
- a) keeping a table of objects already copied during the current
-    copying pass
-
- b) letting user-defined classes override the copying operation or the
-    set of components copied
-
-This version does not copy types like module, class, function, method,
-nor stack trace, stack frame, nor file, socket, window, nor array, nor
-any similar types.
-
-Classes can use the same interfaces to control copying that they use
-to control pickling: they can define methods called __getinitargs__(),
-__getstate__() and __setstate__().  See the documentation for module
-"pickle" for information on these methods.
-"""
-
-import types
-from copy_reg import dispatch_table
-
-class Error(Exception):
-    pass
-error = Error   # backward compatibility
-
-try:
-    from org.python.core import PyStringMap
-except ImportError:
-    PyStringMap = None
-
-__all__ = ["Error", "copy", "deepcopy"]
-
-import inspect
-def _getspecial(cls, name):
-    for basecls in inspect.getmro(cls):
-        try:
-            return basecls.__dict__[name]
-        except:
-            pass
-    else:
-        return None
-
-def copy(x):
-    """Shallow copy operation on arbitrary Python objects.
-
-    See the module's __doc__ string for more info.
-    """
-
-    cls = type(x)
-
-    copier = _copy_dispatch.get(cls)
-    if copier:
-        return copier(x)
-
-    copier = _getspecial(cls, "__copy__")
-    if copier:
-        return copier(x)
-
-    reductor = dispatch_table.get(cls)
-    if reductor:
-        rv = reductor(x)
-    else:
-        reductor = getattr(x, "__reduce_ex__", None)
-        if reductor:
-            rv = reductor(2)
-        else:
-            reductor = getattr(x, "__reduce__", None)
-            if reductor:
-                rv = reductor()
-            else:
-                copier = getattr(x, "__copy__", None)
-                if copier:
-                    return copier()
-                raise Error("un(shallow)copyable object of type %s" % cls)
-
-    return _reconstruct(x, rv, 0)
-
-
-_copy_dispatch = d = {}
-
-def _copy_immutable(x):
-    return x
-for t in (types.NoneType, int, long, float, bool, str, tuple,
-          type, xrange, types.ClassType,
-          types.BuiltinFunctionType):
-    d[t] = _copy_immutable
-try:
-    d[frozenset] = _copy_immutable
-except:
-    pass
-    
-for name in ("ComplexType", "UnicodeType", "CodeType"):
-    t = getattr(types, name, None)
-    if t is not None:
-        d[t] = _copy_immutable
-
-def _copy_with_constructor(x):
-    return type(x)(x)
-for t in (list, dict):
-    d[t] = _copy_with_constructor
-try:
-    d[set] = _copy_with_constructor
-except:
-    pass
-
-def _copy_with_copy_method(x):
-    return x.copy()
-if PyStringMap is not None:
-    d[PyStringMap] = _copy_with_copy_method
-
-def _copy_inst(x):
-    if hasattr(x, '__copy__'):
-        return x.__copy__()
-    if hasattr(x, '__getinitargs__'):
-        args = x.__getinitargs__()
-        y = x.__class__(*args)
-    else:
-        y = _EmptyClass()
-        y.__class__ = x.__class__
-    if hasattr(x, '__getstate__'):
-        state = x.__getstate__()
-    else:
-        state = x.__dict__
-    if hasattr(y, '__setstate__'):
-        y.__setstate__(state)
-    else:
-        y.__dict__.update(state)
-    return y
-d[types.InstanceType] = _copy_inst
-
-del d
-
-def deepcopy(x, memo=None, _nil=[]):
-    """Deep copy operation on arbitrary Python objects.
-
-    See the module's __doc__ string for more info.
-    """
-
-    if memo is None:
-        memo = {}
-
-    d = id(x)
-    y = memo.get(d, _nil)
-    if y is not _nil:
-        return y
-
-    cls = type(x)
-
-    copier = _deepcopy_dispatch.get(cls)
-    if copier:
-        y = copier(x, memo)
-    else:
-        try:
-            issc = issubclass(cls, type)
-        except TypeError: # cls is not a class (old Boost; see SF #502085)
-            issc = 0
-        if issc:
-            y = _deepcopy_atomic(x, memo)
-        else:
-            copier = _getspecial(cls, "__deepcopy__")
-            if copier:
-                y = copier(x, memo)
-            else:
-                reductor = dispatch_table.get(cls)
-                if reductor:
-                    rv = reductor(x)
-                else:
-                    reductor = getattr(x, "__reduce_ex__", None)
-                    if reductor:
-                        rv = reductor(2)
-                    else:
-                        reductor = getattr(x, "__reduce__", None)
-                        if reductor:
-                            rv = reductor()
-                        else:
-                            copier = getattr(x, "__deepcopy__", None)
-                            if copier:
-                                return copier(memo)
-                            raise Error(
-                                "un(deep)copyable object of type %s" % cls)
-                y = _reconstruct(x, rv, 1, memo)
-
-    memo[d] = y
-    _keep_alive(x, memo) # Make sure x lives at least as long as d
-    return y
-
-_deepcopy_dispatch = d = {}
-
-def _deepcopy_atomic(x, memo):
-    return x
-d[types.NoneType] = _deepcopy_atomic
-d[types.IntType] = _deepcopy_atomic
-d[types.LongType] = _deepcopy_atomic
-d[types.FloatType] = _deepcopy_atomic
-d[types.BooleanType] = _deepcopy_atomic
-try:
-    d[types.ComplexType] = _deepcopy_atomic
-except AttributeError:
-    pass
-d[types.StringType] = _deepcopy_atomic
-try:
-    d[types.UnicodeType] = _deepcopy_atomic
-except AttributeError:
-    pass
-try:
-    d[types.CodeType] = _deepcopy_atomic
-except AttributeError:
-    pass
-d[types.TypeType] = _deepcopy_atomic
-d[types.XRangeType] = _deepcopy_atomic
-d[types.ClassType] = _deepcopy_atomic
-d[types.BuiltinFunctionType] = _deepcopy_atomic
-
-def _deepcopy_list(x, memo):
-    y = []
-    memo[id(x)] = y
-    for a in x:
-        y.append(deepcopy(a, memo))
-    return y
-d[types.ListType] = _deepcopy_list
-
-def _deepcopy_tuple(x, memo):
-    y = []
-    for a in x:
-        y.append(deepcopy(a, memo))
-    d = id(x)
-    try:
-        return memo[d]
-    except KeyError:
-        pass
-    for i in range(len(x)):
-        if x[i] is not y[i]:
-            y = tuple(y)
-            break
-    else:
-        y = x
-    memo[d] = y
-    return y
-d[types.TupleType] = _deepcopy_tuple
-
-def _deepcopy_dict(x, memo):
-    y = {}
-    memo[id(x)] = y
-    for key, value in x.iteritems():
-        y[deepcopy(key, memo)] = deepcopy(value, memo)
-    return y
-d[types.DictionaryType] = _deepcopy_dict
-if PyStringMap is not None:
-    d[PyStringMap] = _deepcopy_dict
-
-def _keep_alive(x, memo):
-    """Keeps a reference to the object x in the memo.
-
-    Because we remember objects by their id, we have
-    to assure that possibly temporary objects are kept
-    alive by referencing them.
-    We store a reference at the id of the memo, which should
-    normally not be used unless someone tries to deepcopy
-    the memo itself...
-    """
-    try:
-        memo[id(memo)].append(x)
-    except KeyError:
-        # aha, this is the first one :-)
-        memo[id(memo)]=[x]
-
-def _deepcopy_inst(x, memo):
-    if hasattr(x, '__deepcopy__'):
-        return x.__deepcopy__(memo)
-    if hasattr(x, '__getinitargs__'):
-        args = x.__getinitargs__()
-        args = deepcopy(args, memo)
-        y = x.__class__(*args)
-    else:
-        y = _EmptyClass()
-        y.__class__ = x.__class__
-    memo[id(x)] = y
-    if hasattr(x, '__getstate__'):
-        state = x.__getstate__()
-    else:
-        state = x.__dict__
-    state = deepcopy(state, memo)
-    if hasattr(y, '__setstate__'):
-        y.__setstate__(state)
-    else:
-        y.__dict__.update(state)
-    return y
-d[types.InstanceType] = _deepcopy_inst
-
-def _reconstruct(x, info, deep, memo=None):
-    if isinstance(info, str):
-        return x
-    assert isinstance(info, tuple)
-    if memo is None:
-        memo = {}
-    n = len(info)
-    assert n in (2, 3, 4, 5)
-    callable, args = info[:2]
-    if n > 2:
-        state = info[2]
-    else:
-        state = {}
-    if n > 3:
-        listiter = info[3]
-    else:
-        listiter = None
-    if n > 4:
-        dictiter = info[4]
-    else:
-        dictiter = None
-    if deep:
-        args = deepcopy(args, memo)
-    y = callable(*args)
-    memo[id(x)] = y
-    if listiter is not None:
-        for item in listiter:
-            if deep:
-                item = deepcopy(item, memo)
-            y.append(item)
-    if dictiter is not None:
-        for key, value in dictiter:
-            if deep:
-                key = deepcopy(key, memo)
-                value = deepcopy(value, memo)
-            y[key] = value
-    if state:
-        if deep:
-            state = deepcopy(state, memo)
-        if hasattr(y, '__setstate__'):
-            y.__setstate__(state)
-        else:
-            if isinstance(state, tuple) and len(state) == 2:
-                state, slotstate = state
-            else:
-                slotstate = None
-            if state is not None:
-                y.__dict__.update(state)
-            if slotstate is not None:
-                for key, value in slotstate.iteritems():
-                    setattr(y, key, value)
-    return y
-
-del d
-
-del types
-
-# Helper for instance creation without calling __init__
-class _EmptyClass:
-    pass
-
-def _test():
-    l = [None, 1, 2L, 3.14, 'xyzzy', (1, 2L), [3.14, 'abc'],
-         {'abc': 'ABC'}, (), [], {}]
-    l1 = copy(l)
-    print l1==l
-    l1 = map(copy, l)
-    print l1==l
-    l1 = deepcopy(l)
-    print l1==l
-    class C:
-        def __init__(self, arg=None):
-            self.a = 1
-            self.arg = arg
-            if __name__ == '__main__':
-                import sys
-                file = sys.argv[0]
-            else:
-                file = __file__
-            self.fp = open(file)
-            self.fp.close()
-        def __getstate__(self):
-            return {'a': self.a, 'arg': self.arg}
-        def __setstate__(self, state):
-            for key, value in state.iteritems():
-                setattr(self, key, value)
-        def __deepcopy__(self, memo=None):
-            new = self.__class__(deepcopy(self.arg, memo))
-            new.a = self.a
-            return new
-    c = C('argument sketch')
-    l.append(c)
-    l2 = copy(l)
-    print l == l2
-    print l
-    print l2
-    l2 = deepcopy(l)
-    print l == l2
-    print l
-    print l2
-    l.append({l[1]: l, 'xyz': l[2]})
-    l3 = copy(l)
-    import repr
-    print map(repr.repr, l)
-    print map(repr.repr, l1)
-    print map(repr.repr, l2)
-    print map(repr.repr, l3)
-    l3 = deepcopy(l)
-    import repr
-    print map(repr.repr, l)
-    print map(repr.repr, l1)
-    print map(repr.repr, l2)
-    print map(repr.repr, l3)
-
-if __name__ == '__main__':
-    _test()
--- a/MoinMoin/userprefs/suid.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/MoinMoin/userprefs/suid.py	Fri Jul 20 22:04:55 2007 +0200
@@ -93,7 +93,7 @@
         if not self._only:
             buttons = [html.INPUT(type="submit", name="select_user",
                                   value=_('Select User')),
-                       ' ',]
+                       ' ', ]
         else:
             buttons = []
         buttons.append(html.INPUT(type="submit", name="cancel",
--- a/MoinMoin/wikidicts.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/MoinMoin/wikidicts.py	Fri Jul 20 22:04:55 2007 +0200
@@ -8,11 +8,10 @@
 """
 import re, time
 
-from MoinMoin.support import copy
-
 from MoinMoin import caching, wikiutil, Page, logfile
 from MoinMoin.logfile.editlog import EditLog
 
+
 # Version of the internal data structure which is pickled.
 # Please increment if you have changed the structure.
 DICTS_PICKLE_VERSION = 6
--- a/MoinMoin/wikiutil.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/MoinMoin/wikiutil.py	Fri Jul 20 22:04:55 2007 +0200
@@ -386,7 +386,7 @@
     """ Convert version number to UNIX timestamp (float).
         This must ONLY be used for display purposes.
     """
-    return v/1000000.0
+    return v / 1000000.0
 
 
 # This is the list of meta attribute names to be treated as integers.
@@ -1664,7 +1664,7 @@
         # invalid or empty ticket
         return False
     now = time.time()
-    if timestamp < now - 10*3600:
+    if timestamp < now - 10 * 3600:
         # we don't accept tickets older than 10h
         return False
     ourticket = createTicket(request, timestamp_str)
--- a/wiki/config/wikiconfig.py	Fri Jul 20 13:27:41 2007 +0200
+++ b/wiki/config/wikiconfig.py	Fri Jul 20 22:04:55 2007 +0200
@@ -95,6 +95,11 @@
     # All acl_rights_xxx options must use unicode [Unicode]
     #acl_rights_before = u"YourName:read,write,delete,revert,admin"
 
+    # The default (ENABLED) password_checker will keep users from choosing too
+    # short or too easy passwords. If you don't like this and your site has
+    # rather low security requirements, feel free to DISABLE the checker by:
+    #password_checker = None # None means "don't do any password strength checks"
+
     # Link spam protection for public wikis (Uncomment to enable)
     # Needs a reliable internet connection.
     #from MoinMoin.security.antispam import SecurityPolicy