changeset 939:916f6a5e4ca6

add comment about wrong last-modified code
author Thomas Waldmann <tw AT waldmann-edv DOT de>
date Sun, 16 Jul 2006 13:40:17 +0200
parents 8effe95df6f0
children 595a285e634c
files MoinMoin/Page.py
diffstat 1 files changed, 3 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/MoinMoin/Page.py	Thu Jul 13 22:46:38 2006 +0200
+++ b/MoinMoin/Page.py	Sun Jul 16 13:40:17 2006 +0200
@@ -1174,6 +1174,9 @@
                 else:
                     # use the correct last-modified value from the on-disk file
                     # to ensure cacheability where supported
+                    # TODO: for page likes RecentChanges (generally: ALL pages
+                    # with dynamically changing content), we MUST NOT use the
+                    # page src mtime as last-modified header. XXX
                     request.http_headers(["Last-Modified: " +
                          timefuncs.formathttpdate(os.path.getmtime(self._text_filename()))])