changeset 2830:c4ab7c81146d

Fixed XSS issue in RenamePage/DeletePage action
author Thomas Waldmann <tw AT waldmann-edv DOT de>
date Tue, 11 Sep 2007 18:15:44 +0200
parents 45b438c119d7
children 8f21cc746e81
files MoinMoin/PageEditor.py docs/CHANGES
diffstat 2 files changed, 7 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/MoinMoin/PageEditor.py	Mon Sep 10 22:47:01 2007 +0200
+++ b/MoinMoin/PageEditor.py	Tue Sep 11 18:15:44 2007 +0200
@@ -516,7 +516,8 @@
         newpage = PageEditor(request, newpagename)
 
         pageexists_error = _("""'''A page with the name {{{'%s'}}} already exists.'''
-Try a different name.""") % (newpagename, )
+
+Try a different name.""") % (wikiutil.escape(newpagename), )
 
         # Check whether a page with the new name already exists
         if newpage.exists(includeDeleted=1):
@@ -581,7 +582,7 @@
 
         pageexists_error = _("""'''A page with the name {{{'%s'}}} already exists.'''
 
-Try a different name.""") % (newpagename, )
+Try a different name.""") % (wikiutil.escape(newpagename), )
 
         # Check whether a page with the new name already exists
         if newpage.exists(includeDeleted=1):
@@ -686,7 +687,7 @@
             msg = self.saveText(u"deleted\n", 0, comment=comment or u'', deleted=True, notify=False)
             msg = msg.replace(
                 _("Thank you for your changes. Your attention to detail is appreciated."),
-                _('Page "%s" was successfully deleted!') % (self.page_name, ))
+                _('Page "%s" was successfully deleted!') % (wikiutil.escape(self.page_name), ))
 
             event = PageDeletedEvent(request, self, comment)
             send_event(event)
--- a/docs/CHANGES	Mon Sep 10 22:47:01 2007 +0200
+++ b/docs/CHANGES	Tue Sep 11 18:15:44 2007 +0200
@@ -550,11 +550,14 @@
     * Removed Lupy based indexed search code. If you were brave enough to
       use cfg.lupy_search, you maybe want to try cfg.xapian_search instead.
 
+
 Version 1.5.current:
   Bugfixes:
     * AttachFile overwrite mode (introduced in 1.5.7) did not check delete
       rights, but only write rights. Now it checks that the user has write AND
       delete rights before overwriting a file.
+    * Fixed potential XSS issues related to feeding of gui editor.
+    * Fixed XSS issue in RenamePage/DeletePage action.
 
 Version 1.5.8:
   New features: